fix(keystore): support for build without cgo #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGO and especially
go-ethereum/crypto/secp256k1
adds significant overhead to build time/size. Also it doesn't allow us to build on some platforms at all.go-ethereum has a cgo-safe wrapper for
secp256k1.RecoverPubkey
-crypto.Ecrecover
. So we can use it to fix the problem.https://github.com/ethereum/go-ethereum/blob/6bb13e8e2be3aa8c41460eb11837baba514e19be/crypto/signature_cgo.go#L31-L34
https://github.com/ethereum/go-ethereum/blob/6bb13e8e2be3aa8c41460eb11837baba514e19be/crypto/signature_nocgo.go#L32-L40
Fixes #103, Fixes #111, Fixes #125, Fixes #137, Fixes #139
P.S. Looks like it should resolve windows building issues, but I can't check it.