Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For App Extensions #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mhaleem
Copy link

@mhaleem mhaleem commented Aug 28, 2015

Support Presenting AcitonSheet directly through UIViewController and add precompile preprocessors to avoid compilation errors for App Extensions targets.

@fastred
Copy link
Owner

fastred commented Sep 5, 2015

Thank you for sending this PR!
Do you think it would make sense to use view controller presentation also outside of app extension? It would make the code more straighforward.

AHKActiomSheet is currently presented in UIWindow, because that was the way UIActionSheet worked.

@mhaleem
Copy link
Author

mhaleem commented Sep 5, 2015

That was my first thought to use AHKActionSheet in a viewcontroller incase of app extension but then i found it will not give us the same functionality as it is now, simply with the PR i have submitted you can use the extension viewcontroller itself and the AHKActionSheet will behave exactly the same as it is currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants