fix(k8smeta): handle missing directories/files during /proc scan #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::filesystem::directory_iterator works by retrieving entries on-the-fly as it iterates over them, rather than preloading all entries. This implies that entries could indeed disappear (or appear) between iterations, especially in highly dynamic directories such as /proc/. The loop continues processing other entries even if an exception occurs, allowing for robust and uninterrupted iteration. Signed-off-by: Aldo Lacuku <[email protected]>
Rules files suggestions |
leogr
approved these changes
Nov 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 0e21d6361500972a123577e6c437e1958049d968
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
std::filesystem::directory_iteratorworks by retrieving entries on the fly as it iterates over them,rather than preloading all entries. This implies that entries could indeed disappear (or appear)
between iterations, especially in highly dynamic directories such as
/proc/.The loop continues processing other entries even if an exception occurs,
allowing for robust and uninterrupted iteration.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: