Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): solve validation workflow issues #330

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix(ci): solve validation workflow issues #330

merged 1 commit into from
Aug 29, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@jasondellaluce jasondellaluce changed the title fix(ci): solve validation workflow issues wip: fix(ci): solve validation workflow issues Aug 29, 2023
@github-actions
Copy link

Rules files suggestions

@github-actions
Copy link

Rules files suggestions

@github-actions
Copy link

Rules files suggestions

@poiana poiana added kind/bug Something isn't working area/build and removed do-not-merge/work-in-progress labels Aug 29, 2023
@jasondellaluce jasondellaluce changed the title wip: fix(ci): solve validation workflow issues fix(ci): solve validation workflow issues Aug 29, 2023
@poiana poiana added size/S and removed size/L labels Aug 29, 2023
@jasondellaluce
Copy link
Contributor Author

/close

@jasondellaluce
Copy link
Contributor Author

/reopen

@poiana poiana closed this Aug 29, 2023
@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

@jasondellaluce: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor Author

/reopen

@github-actions
Copy link

Rules files suggestions

@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana reopened this Aug 29, 2023
@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

@jasondellaluce: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the lgtm label Aug 29, 2023
@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

LGTM label has been added.

Git tree hash: 3af284d5e143fa1292609f131c64f6539008e125

@poiana poiana merged commit 7590e96 into master Aug 29, 2023
17 checks passed
@github-actions
Copy link

Rules files suggestions

@poiana poiana deleted the fix/validation-workflow-issues branch August 29, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstemm mstemm mstemm approved these changes

@ahmedameenaim ahmedameenaim Awaiting requested review from ahmedameenaim

@leogr leogr Awaiting requested review from leogr

Assignees

@mstemm mstemm

Labels
approved area/build dco-signoff: yes kind/bug Something isn't working lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasondellaluce @poiana @mstemm