Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fal_client): don't forget to urlencode webhook_url #347

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(fal_client): don't forget to urlencode webhook_url #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions projects/fal_client/src/fal_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from dataclasses import dataclass, field
from functools import cached_property
from typing import Any, AsyncIterator, Iterator, TYPE_CHECKING, Optional, Literal
from urllib.parse import urlencode

import httpx
from httpx_sse import aconnect_sse, connect_sse
Expand Down Expand Up @@ -442,7 +443,7 @@ async def submit(
url += "/" + path.lstrip("/")

if webhook_url is not None:
url += f"?fal_webhook={webhook_url}"
url += "?" + urlencode({"fal_webhook": webhook_url})

headers = {}
if hint is not None:
Expand Down Expand Up @@ -667,7 +668,7 @@ def submit(
url += "/" + path.lstrip("/")

if webhook_url is not None:
url += f"?fal_webhook={webhook_url}"
url += "?" + urlencode({"fal_webhook": webhook_url})

headers = {}
if hint is not None:
Expand Down
Loading