New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image-toolkit): request class conflict #346

Merged

efiop merged 1 commit into main from vedat/fix-request-conflict

Oct 25, 2024

Contributor

badayvedat commented Oct 25, 2024

fixes conflicts between two distinct Request classes.

from urllib.request import Request, urlopen # this one has  a Request from urllib

from .image import *  # noqa: F403 # this one has a Request from fastapi

....

# and now this is using request from fastapi, not urllib
request = Request(url, headers=TEMP_HEADERS)


          fix(image-toolkit): request class conflict

be8dac2

badayvedat requested a review from efiop

October 25, 2024 11:46

efiop approved these changes

View reviewed changes

efiop merged commit b32d4a4 into main

7 checks passed

efiop deleted the vedat/fix-request-conflict branch

October 25, 2024 21:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet