Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): Add initial APIs #197

Merged
merged 6 commits into from
May 30, 2024
Merged

feat(container): Add initial APIs #197

merged 6 commits into from
May 30, 2024

Conversation

kakkoyun
Copy link
Contributor

@kakkoyun kakkoyun commented Apr 30, 2024

Add bare-bone APIs for experimental container support.

Signed-off-by: Kemal Akkoyun [email protected]

@kakkoyun kakkoyun force-pushed the container_support branch 2 times, most recently from 9e76b68 to 231c4be Compare May 1, 2024 16:28
@efiop efiop self-requested a review May 1, 2024 16:39
projects/fal/src/fal/api.py Outdated Show resolved Hide resolved
@kakkoyun kakkoyun force-pushed the container_support branch 2 times, most recently from a41ca26 to 6f14bb1 Compare May 10, 2024 08:43
@kakkoyun kakkoyun marked this pull request as ready for review May 24, 2024 13:52
kakkoyun and others added 4 commits May 28, 2024 14:18
Signed-off-by: Kemal Akkoyun <[email protected]>
@efiop
Copy link
Contributor

efiop commented May 30, 2024

@kakkoyun If you want to merge now (before the backend supports it), feel free to slap xfail markers (see @pytest.mark.xfail in the test file) to your container tests here.

@kakkoyun
Copy link
Contributor Author

Good idea. I'll do it.

@kakkoyun kakkoyun requested a review from efiop May 30, 2024 16:24
@kakkoyun
Copy link
Contributor Author

@efiop Please merge on your own discretion.

@efiop efiop merged commit 64f8968 into main May 30, 2024
5 checks passed
@efiop efiop deleted the container_support branch May 30, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants