fix(fal): inherit all exceptions from FalServerlessException #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
commented
Apr 23, 2024
efiop
force-pushed
the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
from
28615eb
to
deda270
Compare
efiop
force-pushed
the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
from
deda270
to
534938e
Compare
efiop
commented
Apr 23, 2024
Comment on lines
-6
to
-17
|
|
||
| message: str | ||
|
|
||
| hint: str | None | ||
|
|
||
| def __init__(self, message: str, hint: str | None = None) -> None: | ||
| self.message = message | ||
| self.hint = hint | ||
| super().__init__(message) | ||
|
|
||
| def __str__(self) -> str: | ||
| return self.message + (f"\nHint: {self.hint}" if self.hint else "") |
There was a problem hiding this comment.
base exception should as basic as possible (in general, but also because we might have to pickle these) . We don't really need to invent message/hint convention here yet.
efiop
deleted the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a little bit more involved before cloudpickle migration, as you had to put
@mainifyeverywhere. Now we can comfortably do that and leverage this in error handling (e.g. see us passing through our own exceptions).