fix(api): stop other servers if one exited #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
fix-31
branch
2 times, most recently
from
d1890a3
to
395e5af
Compare
efiop
commented
Apr 23, 2024
Comment on lines
-915
to
-927
| event = asyncio.Event() | ||
| # TODO(squat): handle shutdowns gracefully. | ||
| # You cannot add signal handlers to any loop if you're not | ||
| # on the main thread. | ||
| # How can we detect that we are being shut down and stop the | ||
| # uvicorn servers gracefully? | ||
| # loop = asyncio.get_running_loop() | ||
| # loop.add_signal_handler(signal.SIGINT, event.set) | ||
| # loop.add_signal_handler(signal.SIGTERM, event.set) | ||
| await asyncio.gather( | ||
| server.serve_until_event(event), | ||
| metrics_server.serve_until_event(event), | ||
| ) |
There was a problem hiding this comment.
Considering that even serve() itself is not in the main thread - it is not our obligation to set the signal handler here anyway, so we can ignore it for now. Removing these leftovers to not obstruct the view.
`gather` doesn't cancel other tasks automatically, e.g. causing metrics server to keep running if user app failed to `setup()`. Caused by #31
|
For the record: timeout errors are unrelated. Merging for now to have it operational in the upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gatherdoesn't cancel other tasks automatically, e.g. causing metrics server to keep running if user app failed tosetup().Caused by #31