Fix -m flag for IPv6 addresses #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: --my-hostname (or -m) flag is used to pass hostnames test clients are supposed to talk to. Those are the addresses the tested chef client will be pulling changed cookbooks from. Unfortunately, it doesn't work if you try to pass IPv6 address - you'll get an error. In particular, taste-tester test <test_host> -m [IPv6] won't work. The underlying problem is that open opening http(s) connection to the provided hostname we use `uri.host` - this version won't remove [] for IPv6 addresses. There is a replacement `uri.hostname` which will remove square brackets and make the it work. Test Plan: Tested on a host without a change - the error is ``` Failed to open TCP connection to [IPv6]:port (getaddrinfo: Name or service not known) ``` When changed client.rb from `uri.host` to `uri.hostname` everything work. Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
--my-hostname (or -m) flag is used to pass hostnames test clients are supposed to talk to. Those are the addresses the tested chef client will be pulling changed cookbooks from. Unfortunately, it doesn't work if you try to pass IPv6 address - you'll get an error. In particular,
taste-tester test <test_host> -m [IPv6]won't work.The underlying problem is that open opening http(s) connection to the provided hostname we use
uri.host- this version won't remove [] for IPv6 addresses. There is a replacementuri.hostnamewhich will remove square brackets and make the it work.Test Plan:
Tested on a host without a change - the error is
When changed client.rb from
uri.hosttouri.hostnameeverything work.