Remove single identity target type

Summary:
This diff is refctoring target structs. Specifically:
- And, or and Not are deprecated
Instead:
- Rules can be specified severla times to cover Or cases
- A list of identities replaces And
- Single identities can be expressed as a list of identities with a single item
- Static slices now must contain a target that it applies to. Beforehand it required And

Reviewed By: mitrandir77

Differential Revision: D65667107

fbshipit-source-id: a361a680b9400f51448f22986713f53bbbc952be

eden/mononoke/rate_limiting/src/config.rs

@@ -37,9 +37,6 @@ impl TryFrom<rate_limiting_config::Target> for Target {
 
     fn try_from(value: rate_limiting_config::Target) -> Result<Self, Self::Error> {
         match value {
-            rate_limiting_config::Target::identity(i) => {
-                Ok(Target::Identity(FromStr::from_str(&i)?))
-            }
             rate_limiting_config::Target::static_slice(s) => {
                 let slice_pct = s.slice_pct.try_into()?;
                 Ok(Target::StaticSlice(StaticSlice {

eden/mononoke/rate_limiting/src/lib.rs

@@ -15,7 +15,6 @@ use anyhow::Error;
 use async_trait::async_trait;
 use cached_config::ConfigHandle;
 use fbinit::FacebookInit;
-use permission_checker::MononokeIdentity;
 use permission_checker::MononokeIdentitySet;
 use permission_checker::MononokeIdentitySetExt;
 use scuba_ext::MononokeScubaSampleBuilder;
@@ -243,7 +242,6 @@ pub enum RateLimitReason {
 
 #[derive(Debug, Clone)]
 pub enum Target {
-    Identity(MononokeIdentity),
     StaticSlice(StaticSlice),
     MainClientId(String),
     Identities(MononokeIdentitySet),
@@ -295,10 +293,6 @@ impl Target {
                     None => false,
                 }
             }
-            Self::Identity(i) => match identities {
-                Some(client_idents) => client_idents.contains(i),
-                None => false,
-            },
             Self::MainClientId(id) => match main_client_id {
                 Some(client_id) => client_id == id,
                 None => false,
@@ -357,6 +351,7 @@ fn in_throttled_slice(
 #[cfg(test)]
 mod test {
     use mononoke_macros::mononoke;
+    use permission_checker::MononokeIdentity;
 
     use super::*;