Skip to content

Commit

Permalink
Set xattr test to linux only
Browse files Browse the repository at this point in the history
Summary:
What:
Fix for breaking tests
How:
os.*xattr are linux extended attributes

change target to linux only

Reviewed By: MichaelCuevas

Differential Revision: D65845632

fbshipit-source-id: 4374f4ed974f3bd6bcff2f39bcbcfb8ad01b078b
  • Loading branch information
Chris Dinh authored and facebook-github-bot committed Nov 13, 2024
1 parent 35e6d82 commit 23760b5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 3 additions & 0 deletions eden/integration/TARGETS
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,9 @@ python_unittest(
python_unittest(
name = "xattr",
srcs = ["xattr_test.py"],
compatible_with = [
"ovr_config//os:linux",
],
env = artifacts["env"],
supports_static_listing = False,
runtime_deps = artifacts["deps"],
Expand Down
5 changes: 1 addition & 4 deletions eden/integration/lib/skip.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
],
"unixsocket_test.UnixSocketTestHg": True,
"userinfo_test.UserInfoTest": True,
"xattr_test.XattrTestHg": True,

#
# Test classes from the hg integration test binary
#
Expand Down Expand Up @@ -294,9 +294,6 @@
# OSError: AF_UNIX path too long
TEST_DISABLED["unixsocket_test.UnixSocketTest"] = True

# EdenFS on macOS uses NFSv3, which doesn't support extended attributes.
TEST_DISABLED["xattr_test.XattrTest"] = True

# fsck doesn't work on macOS?
TEST_DISABLED["fsck.basic_snapshot_tests.Basic20210712TestDefault"] = True

Expand Down

0 comments on commit 23760b5

Please sign in to comment.