Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTTP1xCodec.cpp #532

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update HTTP1xCodec.cpp #532

wants to merge 3 commits into from

Conversation

SteveSelva
Copy link
Contributor

Updated HTTP1xCodec to allow Response Body for HTTP CONNECT requests when the response status code is either 4xx or 5xx.

@SteveSelva
Update HTTP1xCodec.cpp
6642a5a 
Updated HTTP1xCodec to allow Response Body for HTTP CONNECT requests when the response status code is either 4xx or 5xx.
@SteveSelva SteveSelva mentioned this pull request Nov 7, 2024
Open
afrind
afrind reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Can you add a unit test to proxygen/lib/http/codec/test/HTTP1xCodecTests

proxygen/lib/http/codec/HTTP1xCodec.cpp Outdated Show resolved Hide resolved
@SteveSelva
Update HTTP1xCodec.cpp
a343a29
@SteveSelva
Update HTTP1xCodecTest.cpp
8d8c061 
Added test for checking body with CONNECT request
@facebook-github-bot
Copy link
Contributor

@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrind afrind Awaiting requested review from afrind

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveSelva @facebook-github-bot @afrind