Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add for await of #1559

Open
wants to merge 2 commits into
base: static_h
Choose a base branch
from
Open

Conversation

trossimel-sc
Copy link

@trossimel-sc trossimel-sc commented Nov 4, 2024

Summary

This PR introduces support for the for await of syntax through IR. In detail:

  • The helper function _makeAsyncIterator is used to create an async iterator for a given iterable. It checks if an async iterator method is available; if not, it creates an async iterator from a synchronous iterator by wrapping its results in promises.
  • Added a genAsyncForOfStatement which handles the for await of loop by iterating over the async iterator object. It follows the same rules described here

Test Plan

  • Added 3 unit tests to cover the main behavior of for await of loop

@facebook-github-bot
Copy link
Contributor

Hi @trossimel-sc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@trossimel-sc trossimel-sc changed the title [WIP] Add for await of Add for await of Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants