Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of allocating different sizes of storage in StorageProvider #1504

Open
wants to merge 2 commits into
base: static_h
Choose a base branch
from

Commits on Nov 18, 2024

  1. Define AlignedHeapSegmentBase

    Differential Revision: D61675022
    lavenzg authored and facebook-github-bot committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9d3b625 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Add support of allocating different sizes of storage in StorageProvid…

    …er (facebook#1504)
    
    Summary:
    Pull Request resolved: facebook#1504
    
    Large segment needs to be backed by a large storage size.
    StorageProvider currently always allocate fixed size of storage
    determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE.
    
    This diffs adds support of allocating larger storage with below
    changes:
    1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter.
    2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply
    change the previous fixed storage size to passed in `sz`.
    3. For `ContiguousVAStorageProvider`, use a BitVector to manage
    allocations and deallocations. This can be improved later if we observe
    fragmentations.
    
    The support of enabling different sizes of heap segment will be added
    later.
    
    Differential Revision: D61676721
    lavenzg authored and facebook-github-bot committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    436f431 View commit details
    Browse the repository at this point in the history