BuildX failing for Docker CLI on Windows fixed #1819
Conversation
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.ArgumentMatchers.*; | ||
| import static org.mockito.Mockito.*; |
There was a problem hiding this comment.
Could you please revert these wildcard import changes?
There was a problem hiding this comment.
ok, just used vs-code to do so.
|
|
The failling checks are all some docker init problem...have nothing todo with the code-change. |
| import io.fabric8.maven.docker.config.ConfigHelper; | ||
| import io.fabric8.maven.docker.config.ImageConfiguration; | ||
| import io.fabric8.maven.docker.config.SecretConfiguration; | ||
| import io.fabric8.maven.docker.config.*; |
There was a problem hiding this comment.
Looks like we need to address #1819 (comment) here as well.
There was a problem hiding this comment.
ok tried to revert that aswell
|
@derHeinz : Thanks for your PR. Changes look good to me 👍 Could you please add a line to doc/changelog.md regarding this change? |
done |
|
Fix #1818