#1804 support buildx use of default builder #1805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryan-ashcraft
commented
Jul 23, 2024
| append(cmds, "create", "--driver", "docker-container", "--name", builderName); | ||
| if (nodeName != null) { | ||
| append(cmds, "--node", nodeName); | ||
| } |
There was a problem hiding this comment.
Docker does a nice job of providing meaningful error messages if you try to use the default builder with multiple architectures, etc. For instance:
[INFO] DOCKER> ERROR: Multi-platform build is not supported for the docker driver.
[INFO] DOCKER> Switch to a different driver, or turn on the containerd image store, and try again.
[INFO] DOCKER> Learn more at https://docs.docker.com/go/build-multi-platform/
[ERROR] DOCKER> Error status (1) when building
| @@ -245,27 +245,31 @@ protected void createDirectory(Path cachePath) { | |||
| protected String createBuilder(Path configPath, List<String> buildX, ImageConfiguration imageConfig, BuildDirs buildDirs) throws MojoExecutionException { | |||
| BuildXConfiguration buildXConfiguration = imageConfig.getBuildConfiguration().getBuildX(); | |||
| String builderName = Optional.ofNullable(buildXConfiguration.getBuilderName()).orElse("maven"); | |||
There was a problem hiding this comment.
Recommend turning ignore whitespace on to better highlight the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1804