Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

chore(#485): remove ike-prow-plugin configuration file test-keeper.yml #486

Merged
merged 2 commits into from
May 31, 2018

Conversation

dipak-pawar
Copy link
Contributor

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@alexeykazakov
Copy link
Contributor

[test]

@alien-ike alien-ike changed the title [Do Not Merge] chore(#485): remove ike-prow-plugin configuration file test-keeper.yml chore(#485): remove ike-prow-plugin configuration file test-keeper.yml May 31, 2018
@alien-ike
Copy link

Ike Plugins (test-keeper)

Thank you @dipak-pawar for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.

@MatousJobanek
Copy link

The referenced issue has been already merged and deployed to the new Ike plugins instance, so you can merge this PR

@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #486 into master will decrease coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #486      +/-   ##
=========================================
- Coverage   65.25%   64.3%   -0.96%     
=========================================
  Files          82      81       -1     
  Lines        8516    8339     -177     
=========================================
- Hits         5557    5362     -195     
- Misses       2518    2543      +25     
+ Partials      441     434       -7
Impacted Files Coverage Δ
goasupport/forward_signer.go 40% <0%> (-60%) ⬇️
account/service/tenant.go 40% <0%> (-44.91%) ⬇️
gormsupport/postgres.go 14.28% <0%> (-14.29%) ⬇️
...ion/resourcetype/repository/resource_type_scope.go 32.17% <0%> (-13.13%) ⬇️
controller/resource_roles.go 79.03% <0%> (-6.2%) ⬇️
authorization/role/repository/identity_role.go 82.19% <0%> (-2.74%) ⬇️
authorization/authorization.go 84.28% <0%> (-2.14%) ⬇️
...orization/resourcetype/repository/resource_type.go 64.86% <0%> (-0.93%) ⬇️
controller/user.go 80.95% <0%> (-0.87%) ⬇️
authorization/role/repository/role_mapping.go 63.85% <0%> (-0.86%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4337b41...d10ef9b. Read the comment docs.

@alexeykazakov
Copy link
Contributor

/ok-without-tests

@alexeykazakov
Copy link
Contributor

[test]

@alexeykazakov alexeykazakov merged commit 3fd96d6 into fabric8-services:master May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants