Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage on AWS S3 I/O #326

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

edith-bot
Copy link
Contributor


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes

  • Added some further tests in order to improve coverage on runs w/o pure AWS calls.
  • Increased coverage on S3 URL parsing

Related issue

  • None

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.46% 🎉

Comparison is base (b50c7a4) 96.49% compared to head (abe54d4) 97.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   96.49%   97.96%   +1.46%     
==========================================
  Files          62       62              
  Lines        1913     1913              
==========================================
+ Hits         1846     1874      +28     
+ Misses         67       39      -28     
Flag Coverage Δ
unittests 97.96% <ø> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@fabiocaccamo fabiocaccamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fabiocaccamo fabiocaccamo merged commit 27d7633 into fabiocaccamo:main Aug 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants