-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrueColor: add ingame toggler #1225
base: master
Are you sure you want to change the base?
Conversation
* All TrueColor code is guarded by #ifdef CRISPY_TRUECOLOR. * Extra line breaks before some subheaders no longer used to get some extra vertical space and primary to fit everything on first Crispness page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Before we'll merge this: I'm afraid we have bumped into a small misunderstanding about this switch with @rfomin. While my idea was to have just an in-game switch between paletted/truecolor views (not renderers), and that's what it do now, Roman was meaning full toggling. But as already known, full toggling is a long and different story. Aside from possible turning Another approach is to always have a TrueColor mode, but make it friendly with custom palette tints and take care about expensive translucency. In this case, only running on 16-bit and below display modes will not be possible. Really no idea which way is better. First one is an absolute full mile and have to be more correct in technical terms, second one is probably simpler and shorter. So, for now this PR doesn't do much, except adds some vertical space for Crispness menu. |
I think that's understood. It remains full truecolor rendering under the hood, but merely emulates paletted rendering by loading colormaps from the COLORMAP lump instead of fading RGB values to black. Translucency performance and custom palette issues still remain. |
Yes, absolutely. You know this better than anyone, I know this after months of working with TrueColor code. But Roman wasn't working with TrueColor previously. 🙂 Still, should be merge this PR then? And what is your recommendation for farther compatibility support, i.e. which way we should move? |
Yes, my idea was full toggling and remove the separate true color build. I think the current implementation of the toggle is not very useful. |
This adds simple ingame toggler for "TrueColor Rendering". Few remarks:
PLAYPAL
tinting effects.