Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set SDL music volume #1133

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Always set SDL music volume #1133

merged 2 commits into from
Jan 2, 2024

Conversation

mikeday0
Copy link
Collaborator

@mikeday0 mikeday0 commented Jan 1, 2024

I noticed that the Sigil and Sigil II MP3 soundtracks would always start off at max volume when sideloading. This fixes that.

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God catch, thanks for this! Is any of this applicable to Chocolate Doom?

@mikeday0
Copy link
Collaborator Author

mikeday0 commented Jan 1, 2024

God catch, thanks for this! Is any of this applicable to Chocolate Doom?

No, I think this is exclusive to Crispy.

@mikeday0 mikeday0 merged commit 401940e into master Jan 2, 2024
6 checks passed
@mikeday0 mikeday0 deleted the sdlmusicvolume branch January 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants