Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply brightmaps to translucent and translated columns #1128

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Conversation

JNechaevsky
Copy link
Collaborator

Same idea and aproach as in fabiangreffrath/woof#1340. No new functions, just extended current ones to draw brightmapped pixels. Few remarks:

  • For Doom we deffinitly needed, and it's easy to test with a testing map from Woof's PR. There is not translucent walls in original Specifics, it's a Boom-ism. Small expection was made long time ago for scrolling texture right, AFAIR, just as small possible nicification for NOVA.wad.
  • For Heretic we probably need it. Testing translucent columns was easy, just set MF_SHADOW flag to Phoenix Rod, but testing translucent+translated columns - no idea how. Neigher I am able to run HeHacked, this is what always happening with 1.3 version for DOS (screenshot).
  • For Hexen we most likely need it. Probably ACS allows to set mobj flags? Aside from that, mobj flags MF_SHADOW and MF_ALTSHADOW were used for testing translucent columns. Translucent+translated columns are the same dilemma as in Heretic.
  • For Strife we don't need it, as there is no Crispy brightmaps, and Strife using own aproach with COLORMAP trick.

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@JNechaevsky
Copy link
Collaborator Author

My pleasure! Looks likes all small things are done for Crispy for now, and it's time to take care about Woof.
I'll explain very shortly, as it's wrong place to do it here. Basically, it's smooth lines for ZDoom color scheme. Until smoothing everything is fine:

image

With smoothing lines, however, this happens:

image

See that bright lines are going "too dark while smoothing", and dark brown lines are no longer neat. Bright lines can be fixed by reducing steps to +1 here: https://github.com/fabiangreffrath/woof/blob/master/src/am_map.c#L650-L651, but this is not optimal, does not fix dark brown lines and will break neat smoothing on overlay mode.

Okay, enough for now. It's a visual part, and I always treat the visual things with great trepidation, but I hate to complain without suggesting any solutions, so I'll have to investigate.

@JNechaevsky JNechaevsky merged commit c36d6b1 into master Dec 21, 2023
6 checks passed
@JNechaevsky JNechaevsky deleted the tlcol_bmap branch December 21, 2023 08:58
JNechaevsky added a commit to JNechaevsky/international-doom that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants