Clarified MF_TRANSSHIFT purpose comment in Doom #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For other games the meaningful comments are present.
|
I should have proposed it to Choco in the first place. |
fabiangreffrath
approved these changes
Aug 25, 2023
|
@fabiangreffrath, I have no rights to submit pull requests to Choco. |
|
if you think it's appropriate in Crispy but not Choco (e.g. some Choco philosophy regarding comments), feel free to merge this :) |
|
To be honest, I am not a fan of "fixing" Vanilla comments, either. If you think this needs clarification, an additional comment formulated as some kind of "answer" to the "Hm?" question would be appropriate. |
|
OK, submitted another pull request preserving vanilla comment as a question and my comment as the answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Heretic, Hexen and Strife the meaningful comments are present.