Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add getting started #13

Merged
merged 4 commits into from
Dec 6, 2023
Merged

docs: add getting started #13

merged 4 commits into from
Dec 6, 2023

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Dec 6, 2023

For internal editing convenience, the code from the getting started is here

@G4Vi G4Vi requested a review from zshipko December 6, 2023 19:11
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but looks good!

README.md Outdated
Plug-ins may optionally take a configuration object. This is a static way to configure the plug-in. Our count-vowels plugin takes an optional configuration to change out which characters are considered vowels. Example:

```cpp
// #include ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth just using #include <extism.h> here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to #include <extism.hpp>

@G4Vi G4Vi merged commit 9477fef into main Dec 6, 2023
2 checks passed
@G4Vi G4Vi mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants