Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix for nms bug #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

loge1998
Copy link

Hello Experiencor,
Like all guys, I used your code to train a yolo model with my custom dataset. Your code worked well. I got the mAP value and I want to improve the mAP value. So I drew the pred_boxes around the object and I found a weird behaviour. I saw more than 1 bbox around each object. I was not sure at that time why it is printing like that. Then I added few codes to count true positive,true negative,false positive and all. I found that fp is so high. That is because the multiple bboxes around the same object. Later I found the issue. do_nms function nullify the surrounding bboxes with threshold. Nullify means just change the confidence to zero instead of removing it, this is correct if the bbox is associated with some other object also. But this method will fail, when the bbox is only associated with that particular class. do_nms nullify all the confidence value but the bbox will be still there which is wrong. So I wrote a simple fix for that. I also thought why mAP will still high. Later found that mAP value will not be affected by false positive. Thats why you got the results similar to the original yolo repo. I hope you understand the issue and fix done by me. If you like the work please merge this into master. And great thanks to you for spending your time in doing this cool stuffs which saves many people's time.

@loge1998
Copy link
Author

loge1998 commented Oct 5, 2021

Hi @experiencor Any update on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant