Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Experiencor,
Like all guys, I used your code to train a yolo model with my custom dataset. Your code worked well. I got the mAP value and I want to improve the mAP value. So I drew the pred_boxes around the object and I found a weird behaviour. I saw more than 1 bbox around each object. I was not sure at that time why it is printing like that. Then I added few codes to count true positive,true negative,false positive and all. I found that fp is so high. That is because the multiple bboxes around the same object. Later I found the issue. do_nms function nullify the surrounding bboxes with threshold. Nullify means just change the confidence to zero instead of removing it, this is correct if the bbox is associated with some other object also. But this method will fail, when the bbox is only associated with that particular class. do_nms nullify all the confidence value but the bbox will be still there which is wrong. So I wrote a simple fix for that. I also thought why mAP will still high. Later found that mAP value will not be affected by false positive. Thats why you got the results similar to the original yolo repo. I hope you understand the issue and fix done by me. If you like the work please merge this into master. And great thanks to you for spending your time in doing this cool stuffs which saves many people's time.