Skip to content
This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

Update Dockerfile #44

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 19 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@ jobs:
- name: test
run: yarn test

# Test builds
- name: build
run: yarn build
- name: build docker images
run: |
# Build docker image
docker build -f docker/Dockerfile --quiet .
# Build debug docker image
docker build -f docker/Dockerfile.debug --quiet .

# upload coverage
- name: Coveralls
uses: coverallsapp/github-action@master
Expand Down
9 changes: 4 additions & 5 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
FROM node:12.15-alpine
FROM node:lts-alpine

# install docker-compose
RUN apk update \
&& apk add --no-cache py-pip python-dev \
libffi-dev openssl-dev gcc libc-dev make \
&& pip install docker-compose
RUN apk add curl
RUN curl -L --fail https://github.com/docker/compose/releases/download/1.29.0/run.sh -o /usr/local/bin/docker-compose
FDiskas marked this conversation as resolved.
Show resolved Hide resolved
RUN chmod +x /usr/local/bin/docker-compose

# create new workdir
WORKDIR /app
Expand Down
8 changes: 5 additions & 3 deletions docker/Dockerfile.debug
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM node:12
FROM node:lts-alpine

# install required libs, docker-compose and yarn
RUN apt-get update && apt-get install python-pip -y && pip install docker-compose
# install required libs, docker-compose
RUN apk add curl
RUN curl -L --fail https://github.com/docker/compose/releases/download/1.29.0/run.sh -o /usr/local/bin/docker-compose
RUN chmod +x /usr/local/bin/docker-compose

# create folder and set it as workdir
RUN mkdir -p /usr/src/app
Expand Down