Merge pull request #82 from ethz-asl/feature/add_py_typed_marker_file

Mark pywavemap as a typed extension and address cpplint v2.0 warnings
ethz-asl · Oct 25, 2024 · d0d64d8 · d0d64d8
2 parents 54b2a93 + 7790319
commit d0d64d8
Show file tree

Hide file tree

Showing 98 changed files with 283 additions and 17 deletions.
diff --git a/CPPLINT.cfg b/CPPLINT.cfg
@@ -11,8 +11,11 @@ filter=-legal/copyright
 # clang-format.
 filter=-build/include_order
 
-# Do not check for unapproved C++11 headers such as <chrono> and <thread>.
-# We currently do not have a better alternative (e.g. abseil) that is already
-# available, although adding such a dependency would be worth considering in the
-# future.
-filter=-build/c++11
+# Do not forbid using C++11 and C++17 headers that are not approved by Google,
+# such as <chrono> and <thread>. These STL components worked well enough for us
+# so far that we do not yet see the need to add a dependency that provides
+# alternatives (e.g. abseil).
+filter=-build/c++11,-build/c++17
+
+# Our project's style expects the contents of a namespace to be indented
+filter=-whitespace/indent_namespace
diff --git a/examples/cpp/CHANGELOG.rst b/examples/cpp/CHANGELOG.rst
@@ -2,6 +2,9 @@
 Changelog for package wavemap_examples_cpp
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+
 2.1.0 (2024-09-16)
 ------------------
 * Extend and improve documentation and examples

diff --git a/examples/cpp/CMakeLists.txt b/examples/cpp/CMakeLists.txt
@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.10)
-project(wavemap_examples_cpp VERSION 2.1.0 LANGUAGES CXX)
+project(wavemap_examples_cpp VERSION 2.1.1 LANGUAGES CXX)
 
 # Load the wavemap library
 # First, try to load it from sources

diff --git a/examples/python/CHANGELOG.rst b/examples/python/CHANGELOG.rst
@@ -2,6 +2,9 @@
 Changelog for package wavemap_examples_python
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+
 2.1.0 (2024-09-16)
 ------------------
 * Initial examples and documentation on how to use wavemap's Python API

diff --git a/examples/ros1/CHANGELOG.rst b/examples/ros1/CHANGELOG.rst
@@ -2,6 +2,11 @@
 Changelog for package wavemap_examples_ros1
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+* Address warnings from new cpplint version (v2.0)
+* Contributors: Victor Reijgwart
+
 2.1.0 (2024-09-16)
 ------------------
 

diff --git a/examples/ros1/io/send_map_over_ros.cc b/examples/ros1/io/send_map_over_ros.cc
@@ -1,3 +1,5 @@
+#include <string>
+
 #include <ros/ros.h>
 #include <wavemap_ros_conversions/map_msg_conversions.h>
 

diff --git a/examples/ros1/package.xml b/examples/ros1/package.xml
@@ -1,7 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <package format="2">
   <name>wavemap_examples_ros1</name>
-  <version>2.1.0</version>
+  <version>2.1.1</version>
   <description>Usages examples for wavemap's ROS1 interface.</description>
 
   <maintainer email="[email protected]">Victor Reijgwart</maintainer>

diff --git a/interfaces/ros1/wavemap/CHANGELOG.rst b/interfaces/ros1/wavemap/CHANGELOG.rst
@@ -2,6 +2,9 @@
 Changelog for package wavemap
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+
 2.1.0 (2024-09-16)
 ------------------
 

diff --git a/interfaces/ros1/wavemap/package.xml b/interfaces/ros1/wavemap/package.xml
@@ -1,7 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <package format="2">
   <name>wavemap</name>
-  <version>2.1.0</version>
+  <version>2.1.1</version>
   <description>Base library for wavemap.</description>
 
   <maintainer email="[email protected]">Victor Reijgwart</maintainer>

diff --git a/interfaces/ros1/wavemap_all/CHANGELOG.rst b/interfaces/ros1/wavemap_all/CHANGELOG.rst
@@ -2,6 +2,9 @@
 Changelog for package wavemap_all
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+
 2.1.0 (2024-09-16)
 ------------------
 

diff --git a/interfaces/ros1/wavemap_all/package.xml b/interfaces/ros1/wavemap_all/package.xml
@@ -1,7 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <package format="2">
   <name>wavemap_all</name>
-  <version>2.1.0</version>
+  <version>2.1.1</version>
   <description>Metapackage that builds all wavemap packages.</description>
 
   <maintainer email="[email protected]">Victor Reijgwart</maintainer>

diff --git a/interfaces/ros1/wavemap_msgs/CHANGELOG.rst b/interfaces/ros1/wavemap_msgs/CHANGELOG.rst
@@ -2,6 +2,9 @@
 Changelog for package wavemap_msgs
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+
 2.1.0 (2024-09-16)
 ------------------
 

diff --git a/interfaces/ros1/wavemap_msgs/package.xml b/interfaces/ros1/wavemap_msgs/package.xml
@@ -1,7 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <package format="2">
   <name>wavemap_msgs</name>
-  <version>2.1.0</version>
+  <version>2.1.1</version>
   <description>Message definitions for wavemap's ROS interfaces.</description>
 
   <maintainer email="[email protected]">Victor Reijgwart</maintainer>

diff --git a/interfaces/ros1/wavemap_ros/CHANGELOG.rst b/interfaces/ros1/wavemap_ros/CHANGELOG.rst
@@ -2,6 +2,11 @@
 Changelog for package wavemap_ros
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+* Address warnings from new cpplint version (v2.0)
+* Contributors: Victor Reijgwart
+
 2.1.0 (2024-09-16)
 ------------------
 

diff --git a/interfaces/ros1/wavemap_ros/app/rosbag_processor.cc b/interfaces/ros1/wavemap_ros/app/rosbag_processor.cc
@@ -1,5 +1,7 @@
 #include "wavemap_ros/utils/rosbag_processor.h"
 
+#include <string>
+
 #include <glog/logging.h>
 #include <rosgraph_msgs/Clock.h>
 #include <tf/tfMessage.h>

diff --git a/interfaces/ros1/wavemap_ros/package.xml b/interfaces/ros1/wavemap_ros/package.xml
@@ -1,7 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <package format="2">
   <name>wavemap_ros</name>
-  <version>2.1.0</version>
+  <version>2.1.1</version>
   <description>ROS interface for wavemap.</description>
 
   <maintainer email="[email protected]">Victor Reijgwart</maintainer>

diff --git a/interfaces/ros1/wavemap_ros/src/inputs/depth_image_topic_input.cc b/interfaces/ros1/wavemap_ros/src/inputs/depth_image_topic_input.cc
@@ -1,5 +1,10 @@
 #include "wavemap_ros/inputs/depth_image_topic_input.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #include <cv_bridge/cv_bridge.h>
 #include <opencv2/core/eigen.hpp>
 #include <sensor_msgs/PointCloud.h>

diff --git a/interfaces/ros1/wavemap_ros/src/inputs/pointcloud_topic_input.cc b/interfaces/ros1/wavemap_ros/src/inputs/pointcloud_topic_input.cc
@@ -1,5 +1,9 @@
 #include "wavemap_ros/inputs/pointcloud_topic_input.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+
 #include <cv_bridge/cv_bridge.h>
 #include <opencv2/core/eigen.hpp>
 #include <sensor_msgs/PointCloud.h>

diff --git a/interfaces/ros1/wavemap_ros/src/inputs/ros_input_base.cc b/interfaces/ros1/wavemap_ros/src/inputs/ros_input_base.cc
@@ -1,5 +1,9 @@
 #include "wavemap_ros/inputs/ros_input_base.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+
 namespace wavemap {
 DECLARE_CONFIG_MEMBERS(RosInputBaseConfig,
                       (topic_name)

diff --git a/interfaces/ros1/wavemap_ros/src/inputs/ros_input_factory.cc b/interfaces/ros1/wavemap_ros/src/inputs/ros_input_factory.cc
@@ -1,5 +1,9 @@
 #include "wavemap_ros/inputs/ros_input_factory.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+
 #include "wavemap_ros/inputs/depth_image_topic_input.h"
 #include "wavemap_ros/inputs/pointcloud_topic_input.h"
 

diff --git a/interfaces/ros1/wavemap_ros/src/map_operations/crop_map_operation.cc b/interfaces/ros1/wavemap_ros/src/map_operations/crop_map_operation.cc
@@ -1,5 +1,9 @@
 #include "wavemap_ros/map_operations/crop_map_operation.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+
 #include <wavemap/core/map/hashed_blocks.h>
 #include <wavemap/core/map/hashed_chunked_wavelet_octree.h>
 #include <wavemap/core/map/hashed_wavelet_octree.h>

diff --git a/interfaces/ros1/wavemap_ros/src/map_operations/map_ros_operation_factory.cc b/interfaces/ros1/wavemap_ros/src/map_operations/map_ros_operation_factory.cc
@@ -1,5 +1,9 @@
 #include "wavemap_ros/map_operations/map_ros_operation_factory.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+
 #include "wavemap_ros/map_operations/crop_map_operation.h"
 #include "wavemap_ros/map_operations/publish_map_operation.h"
 #include "wavemap_ros/map_operations/publish_pointcloud_operation.h"

diff --git a/interfaces/ros1/wavemap_ros/src/map_operations/publish_map_operation.cc b/interfaces/ros1/wavemap_ros/src/map_operations/publish_map_operation.cc
@@ -1,5 +1,9 @@
 #include "wavemap_ros/map_operations/publish_map_operation.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+
 #include <std_srvs/Empty.h>
 #include <wavemap/core/utils/profiler_interface.h>
 #include <wavemap_msgs/Map.h>

diff --git a/interfaces/ros1/wavemap_ros/src/map_operations/publish_pointcloud_operation.cc b/interfaces/ros1/wavemap_ros/src/map_operations/publish_pointcloud_operation.cc
@@ -1,5 +1,8 @@
 #include "wavemap_ros/map_operations/publish_pointcloud_operation.h"
 
+#include <string>
+#include <utility>
+
 #include <sensor_msgs/PointCloud.h>
 #include <sensor_msgs/PointCloud2.h>
 #include <sensor_msgs/point_cloud_conversion.h>

diff --git a/interfaces/ros1/wavemap_ros/src/ros_server.cc b/interfaces/ros1/wavemap_ros/src/ros_server.cc
@@ -1,5 +1,8 @@
 #include "wavemap_ros/ros_server.h"
 
+#include <memory>
+#include <utility>
+
 #include <std_srvs/Trigger.h>
 #include <wavemap/core/map/map_factory.h>
 #include <wavemap/io/file_conversions.h>

diff --git a/interfaces/ros1/wavemap_ros/src/utils/pointcloud_undistorter.cc b/interfaces/ros1/wavemap_ros/src/utils/pointcloud_undistorter.cc
@@ -1,5 +1,7 @@
 #include "wavemap_ros/utils/pointcloud_undistorter.h"
 
+#include <string>
+
 #include <wavemap/core/utils/profiler_interface.h>
 #include <wavemap/core/utils/undistortion/pointcloud_undistortion.h>
 #include <wavemap_ros_conversions/time_conversions.h>

diff --git a/interfaces/ros1/wavemap_ros/src/utils/ros_logging_level.cc b/interfaces/ros1/wavemap_ros/src/utils/ros_logging_level.cc
@@ -1,5 +1,7 @@
 #include "wavemap_ros/utils/ros_logging_level.h"
 
+#include <string>
+
 namespace wavemap {
 RosLoggingLevel::operator LoggingLevel() const {
   if (id_ == Id::kDebug) {

diff --git a/interfaces/ros1/wavemap_ros/src/utils/rosbag_processor.cc b/interfaces/ros1/wavemap_ros/src/utils/rosbag_processor.cc
@@ -1,5 +1,7 @@
 #include "wavemap_ros/utils/rosbag_processor.h"
 
+#include <string>
+
 #include <wavemap/core/utils/profiler_interface.h>
 
 namespace wavemap {

diff --git a/interfaces/ros1/wavemap_ros_conversions/CHANGELOG.rst b/interfaces/ros1/wavemap_ros_conversions/CHANGELOG.rst
@@ -2,6 +2,11 @@
 Changelog for package wavemap_ros_conversions
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+* Address warnings from new cpplint version (v2.0)
+* Contributors: Victor Reijgwart
+
 2.1.0 (2024-09-16)
 ------------------
 

diff --git a/interfaces/ros1/wavemap_ros_conversions/package.xml b/interfaces/ros1/wavemap_ros_conversions/package.xml
@@ -1,7 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <package format="2">
   <name>wavemap_ros_conversions</name>
-  <version>2.1.0</version>
+  <version>2.1.1</version>
   <description>Conversions between wavemap and ROS types.</description>
 
   <maintainer email="[email protected]">Victor Reijgwart</maintainer>

diff --git a/interfaces/ros1/wavemap_ros_conversions/src/config_conversions.cc b/interfaces/ros1/wavemap_ros_conversions/src/config_conversions.cc
@@ -1,5 +1,7 @@
 #include "wavemap_ros_conversions/config_conversions.h"
 
+#include <string>
+
 namespace wavemap::param::convert {
 param::Map toParamMap(const ros::NodeHandle& nh, const std::string& ns) {
   XmlRpc::XmlRpcValue xml_rpc_value;

diff --git a/interfaces/ros1/wavemap_ros_conversions/src/map_msg_conversions.cc b/interfaces/ros1/wavemap_ros_conversions/src/map_msg_conversions.cc
@@ -1,5 +1,11 @@
 #include "wavemap_ros_conversions/map_msg_conversions.h"
 
+#include <algorithm>
+#include <memory>
+#include <stack>
+#include <string>
+#include <unordered_set>
+
 #include <ros/console.h>
 #include <wavemap/core/utils/profiler_interface.h>
 

diff --git a/interfaces/ros1/wavemap_ros_conversions/test/src/test_map_msg_conversions.cc b/interfaces/ros1/wavemap_ros_conversions/test/src/test_map_msg_conversions.cc
@@ -1,3 +1,7 @@
+#include <memory>
+#include <string>
+#include <vector>
+
 #include <gtest/gtest.h>
 #include <wavemap/core/common.h>
 #include <wavemap/core/map/hashed_chunked_wavelet_octree.h>

diff --git a/interfaces/ros1/wavemap_rviz_plugin/CHANGELOG.rst b/interfaces/ros1/wavemap_rviz_plugin/CHANGELOG.rst
@@ -2,6 +2,11 @@
 Changelog for package wavemap_rviz_plugin
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.1.1 (2024-10-24)
+------------------
+* Address warnings from new cpplint version (v2.0)
+* Contributors: Victor Reijgwart
+
 2.1.0 (2024-09-16)
 ------------------
 

diff --git a/interfaces/ros1/wavemap_rviz_plugin/package.xml b/interfaces/ros1/wavemap_rviz_plugin/package.xml
@@ -1,7 +1,7 @@
 <?xml version='1.0' encoding='utf-8'?>
 <package format="2">
   <name>wavemap_rviz_plugin</name>
-  <version>2.1.0</version>
+  <version>2.1.1</version>
   <description>Plugin to interactively visualize maps published in wavemap's
     native format.
   </description>

diff --git a/interfaces/ros1/wavemap_rviz_plugin/src/utils/listeners.cc b/interfaces/ros1/wavemap_rviz_plugin/src/utils/listeners.cc
@@ -1,5 +1,8 @@
 #include "wavemap_rviz_plugin/utils/listeners.h"
 
+#include <memory>
+#include <utility>
+
 #include <glog/logging.h>
 
 namespace wavemap::rviz_plugin {

diff --git a/interfaces/ros1/wavemap_rviz_plugin/src/visuals/cell_layer.cc b/interfaces/ros1/wavemap_rviz_plugin/src/visuals/cell_layer.cc
@@ -1,6 +1,9 @@
 #include "wavemap_rviz_plugin/visuals/cell_layer.h"
 
+#include <algorithm>
+#include <memory>
 #include <sstream>
+#include <vector>
 
 #include <OgreCamera.h>
 #include <OgreMaterialManager.h>

diff --git a/interfaces/ros1/wavemap_rviz_plugin/src/visuals/cell_selector.cc b/interfaces/ros1/wavemap_rviz_plugin/src/visuals/cell_selector.cc
@@ -1,5 +1,7 @@
 #include "wavemap_rviz_plugin/visuals/cell_selector.h"
 
+#include <utility>
+
 #include <wavemap/core/utils/neighbors/grid_neighborhood.h>
 
 namespace wavemap::rviz_plugin {

diff --git a/interfaces/ros1/wavemap_rviz_plugin/src/visuals/slice_visual.cc b/interfaces/ros1/wavemap_rviz_plugin/src/visuals/slice_visual.cc
@@ -1,5 +1,9 @@
 #include "wavemap_rviz_plugin/visuals/slice_visual.h"
 
+#include <memory>
+#include <utility>
+#include <vector>
+
 #include <ros/console.h>
 #include <wavemap/core/indexing/index_conversions.h>
 

diff --git a/interfaces/ros1/wavemap_rviz_plugin/src/visuals/voxel_visual.cc b/interfaces/ros1/wavemap_rviz_plugin/src/visuals/voxel_visual.cc
@@ -1,5 +1,11 @@
 #include "wavemap_rviz_plugin/visuals/voxel_visual.h"
 
+#include <algorithm>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #include <rviz/properties/parse_color.h>
 #include <rviz/render_panel.h>
 #include <wavemap/core/indexing/index_conversions.h>

diff --git a/interfaces/ros1/wavemap_rviz_plugin/src/wavemap_map_display.cc b/interfaces/ros1/wavemap_rviz_plugin/src/wavemap_map_display.cc
@@ -1,5 +1,8 @@
 #include "wavemap_rviz_plugin/wavemap_map_display.h"
 
+#include <memory>
+#include <string>
+
 #include <OGRE/OgreSceneNode.h>
 #include <qfiledialog.h>
 #include <rviz/visualization_manager.h>