Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add functionality of producing hashedNode #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature: Add functionality of producing hashedNode #438

wants to merge 1 commit into from

Conversation

tianyueli8227
Copy link

When I am creating my own Hashing mechanism based on go-verkle library, I notice that there are couple functionality pretty necessary for the library to have but is missing currently. The first one is to create some HashedNode{}, and the second one is to get the starting point of starting Hashing Nodes for some given path.

I have added these two functions as HashNodeFromInternal and GetInternalNode. Please review.

gballet
gballet reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@gballet gballet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HashedNode is an internal representation that we expect to not make public in the future.

Could you please clarify why you think that these two functions are necessary, and if there is indeed a justification for them, add unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet gballet left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianyueli8227 @gballet @TianyueLi1227