Make GetProofItems capable of resolving hashed nodes #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
approved these changes
Jul 11, 2023
tree.go
Outdated
Comment on lines
837
to
853
| pe.Vals = append(pe.Vals, nil) | ||
| for _ = range group { | ||
| // Append one nil value per key in this missing stem | ||
| pe.Vals = append(pe.Vals, nil) | ||
| } |
There was a problem hiding this comment.
Maybe this is known, but looks overlapping with the other PR.
gballet
force-pushed
the
fix-resolution-in-get-proof-items
branch
from
89d284b
to
9e9d894
Compare
|
I'm going to directly fix the open storage trie commit, it should be simpler than implementing this. This PR can still be needed in case the tree that is being proven can not fit in RAM, so I'm not closing it right away. |
gballet
force-pushed
the
fix-resolution-in-get-proof-items
branch
from
9e9d894
to
f715a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.