stateless: add a test for GetCommitmentsAlongPath #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix commitment calculation in insert into leaf * fix insertion in leaf
* Do not use an overwritten FrZero * a more thorough fix: instantiate a new zero
gballet
force-pushed
the
ipa-stateless
branch
from
1b3e0f7
to
aea74d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a stateless sync, a client must be able to work on a stateless verkle tree, and calculate its root commitment. It remains an open question whether there is a use case for building a proof from a stateless tree. It is possible, because in order to be usable, the tree needs to contain enough information to be updatable. This PR is a first attempt at implementing this.
Currently,
GetCommitmentAlongPathdoes not return enough information to be able to provide a proof - siblings that are not in the map, are not returned. This is not currently possible, becauseStatelessNodedoes not support "collapsed" or "hashed" nodes.