-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #370, make TimeTriggerConfig pub and add examples for time_trigger
#372
base: main
Are you sure you want to change the base?
Conversation
00b9b1c
to
02a9f86
Compare
02a9f86
to
bbfad0e
Compare
Fix CI at #377 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice example!
One question added.
bbfad0e
to
9fa2936
Compare
This is gtg, just waiting on the #367 |
any updates on this come on pls |
1 similar comment
any updates on this come on pls |
Still waiting on the other PR |
i copied it over to my machine and i see that it only triggers for the current process, for example, if i set the time interval to be 1 minute and i kill it and start again after one minute it doesnt roll the log. i would like this lib to be exactly like the NLog in c# |
Thanks. You are right about it. For now, I use static variable to store the start time, so after closing the program, the timer will restart. My next goal is to read the start time from file, which will solve your issue. However, now we have a series of PR blocked, including some big structural changes. Therefore, I plan to do it after these PR merged(If I still have time). |
Ok no problems, thank you. For now i will use SizeTrigger. |
Close #370