Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Documentation migration from RTD to ESP-Docs #8650

Closed

Conversation

pedrominatel
Copy link
Member

@pedrominatel pedrominatel commented Sep 19, 2023

This PR will migrate the documentation from Read The Docs to ESP-Docs.

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide

TODO

  1. Add the deploy to CI based on the ESP-Docs documentation

Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

TBD

Related links

This PR will replace the #7083

@pedrominatel pedrominatel self-assigned this Sep 19, 2023
@pedrominatel pedrominatel marked this pull request as draft September 19, 2023 07:24
@pedrominatel pedrominatel added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Sep 19, 2023
@VojtechBartoska
Copy link
Contributor

  • old links redirect
  • update the links in Readme.md

@pedrominatel pedrominatel marked this pull request as ready for review December 7, 2023 02:40
powerfeatherdev and others added 4 commits January 8, 2024 14:35
* Fix and add pin definitions

Add pins D7, D8
Correct pin numbers for ALARM and EN

* Enable CDC on boot

* Use partition schemes appropriate for flash size

Also adds another partition scheme based of off default_8MB, but fat
partition.
* feat(ledc): Allow custom channel selection

* fix(ledc): Fix check of maximum channel

* docs(ledc): Add ledcAttachChannel to docs

* feat(ledc): Change channel to uint8_t + add log message
unTone() does not stop until the queue is exhausted. Therefore, we added clearing the queue.
Copy link
Contributor

github-actions bot commented Jan 12, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "3.0.0-alpha3 escaping fix (#8968)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add v6 support to IPAddress to match ArduinoCore-API (#7174)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added CI for deploy docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added CI for deploy docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added example to demonstrate using HardwareSerial with RS485 interfaces (#8941)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Added missing identifiers in esp_vfs_littlefs_conf_t (#9046)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added new releases to the Arduino versions file":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added new releases to the Arduino versions file":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added versions to JS file and docs as artifact":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added versions to JS file and docs as artifact":
    • summary looks empty
    • type/action looks empty
  • the commit message "Adding Shared GitHub DangerJS (#8983)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Bump tj-actions/changed-files from 36 to 41 in /.github/workflows (#9060)":
    • summary looks empty
    • type/action looks empty
  • the commit message "DNSServer refactoring, switch to AsyncUDP (#7482)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server - Change the URL":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server - Change the URL":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server CI changes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server CI changes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server add type var":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server add type var":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server":
    • summary looks empty
    • type/action looks empty
  • the commit message "Deploy on preview server":
    • summary looks empty
    • type/action looks empty
  • the commit message "Docs build target fix":
    • summary looks empty
    • type/action looks empty
  • the commit message "Docs build target fix":
    • summary looks empty
    • type/action looks empty
  • the commit message "Docs deploy CI updated for production deployment":
    • summary looks empty
    • type/action looks empty
  • the commit message "Docs deploy CI updated for production deployment":
    • summary looks empty
    • type/action looks empty
  • the commit message "Documentation CI build changed to ESP-Docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Documentation CI build changed to ESP-Docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Documentation build and deploy CI changed":
    • summary looks empty
    • type/action looks empty
  • the commit message "Documentation build and deploy CI changed":
    • summary looks empty
    • type/action looks empty
  • the commit message "ESP32-S3 PowerFeather Fixes (#9052)":
    • summary looks empty
    • type/action looks empty
  • the commit message "ESPLwIPClient::setTimeout conflict fix with Stream::setTimeout (#6676)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix documentation CI build":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix documentation CI build":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix index.rst title wirh ESP target":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix index.rst title wirh ESP target":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed env vars from server side URL base":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed env vars from server side URL base":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed env vars from server side":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed env vars from server side":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed the JSON wrong link":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed the JSON wrong link":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed the path for the ResetReason example":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixes ESP32-S2 CDC Debug Logging (#7284)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixes EspClass::deepSleep(64 bits) (#9077)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixes Malloc (#9012)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Improve Log Messages in GPIO HAL (#9011)":
    • summary looks empty
    • type/action looks empty
  • the commit message "LEDC - Allow custom channel selection (#9031)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Merge RTD to ESP-Docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Merge RTD to ESP-Docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Merge conflicts resolved in the new docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Merge conflicts resolved in the new docs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Merge issue on the filename fixed":
    • summary looks empty
    • type/action looks empty
  • the commit message "Pin fixes for the Camera board (#9021)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Removed the version and target selection for now":
    • summary looks empty
    • type/action looks empty
  • the commit message "Removed the version and target selection for now":
    • summary looks empty
    • type/action looks empty
  • the commit message "Replace new with malloc for non-class calls (#7868)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Resolving ADC conflict issue":
    • summary looks empty
    • type/action looks empty
  • the commit message "SD library: Fix format (#9034)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update reset_reason.rst (#8982)":
    • summary looks empty
    • type/action looks empty
  • the commit message "WiFiClients.setConnectionTimeout added (#8863)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Wifi async scan example and fix (#8981)":
    • summary looks empty
    • type/action looks empty
  • the commit message "change(senseBox MCU-S2 ESP32-S2): Remove analog bit resolution change in init (#9000)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "sd_diskio.cpp: return 0 instead of false when return type != bool (#9075)":
    • summary looks empty
    • type/action looks empty
  • the commit message "undeprecate available() (#9027)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 72 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 2742), you might consider splitting it into smaller PRs

👋 Hello pedrominatel, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 73d5027

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
16 out of 17 committers have signed the CLA.

✅ VojtechBartoska
✅ lyusupov
✅ JAndrassy
✅ bkari02
✅ mrengineer7777
✅ SuGlider
✅ ladyada
✅ econeale
✅ a1ext
✅ vortigont
✅ sgryphon
✅ everslick
✅ prplz
✅ lbernstone
✅ tanakamasayuki
✅ powerfeatherdev
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@pedrominatel
Copy link
Member Author

Closed. please see #9094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.