Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KinCony A24 #882

Closed
wants to merge 47 commits into from
Closed

Add KinCony A24 #882

wants to merge 47 commits into from

Conversation

hzkincony
Copy link
Contributor

Add KinCony A24

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 182a587
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/67305a1bd5c12c0008dde6d8
😎 Deploy Preview https://deploy-preview-882--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 5 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@tekmaven tekmaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra files in this pull request.

---
title: KinCony-A24 (with K-Type thermocouple Relay Controller)
date-published: 2024-10-12

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty line

@tekmaven
Copy link
Collaborator

tekmaven commented Nov 9, 2024

This PR contains devices besides A24 and is now conflicted, could you take a look? The other devices should be removed. Otherwise it looks good.

@tekmaven
Copy link
Collaborator

This PR changes files other than the device you are trying to add, which is causing a conflict. Please remove all other devices from the PR. The changed files in the PR tab should only should the one device.

@hzkincony hzkincony closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants