Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aw9523): add auto_init to config #116

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat(aw9523): add auto_init to config #116

merged 1 commit into from
Oct 19, 2023

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Oct 19, 2023 •
edited
Loading

Description

  • Update aw9523 config to have auto_init (default true)
  • Update aw9523 constructor to call initialize() if config.auto_init is set to true
  • Rebuild docs

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project

@finger563
feat(aw9523): add auto_init to config
d8eb602 
* Update aw9523 config to have auto_init (default true)
* Update aw9523 constructor to call initialize() if config.auto_init is set to true
* Rebuild docs
@finger563 finger563 merged commit 0f509e5 into main Oct 19, 2023
1 check passed
@finger563 finger563 deleted the feature/aw9523-auto-init branch October 19, 2023 21:17
@finger563 finger563 added enhancement New feature or request aw9523 labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
aw9523 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@finger563