Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndef): flesh out ble oob ndef record #112

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(ndef): flesh out ble oob ndef record #112

merged 1 commit into from
Oct 16, 2023

Conversation

finger563
Copy link
Contributor

Description

  • Add public address type to mac address field
  • Add flags EIR and update eir to handle flags field

Motivation and Context

Fixes issue with adding EIR Flags field and produces working BLE OOB pairing record.

Tested as part of finger563/esp-nfc-pairing-example#1

How has this been tested?

See finger563/esp-nfc-pairing-example#1

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Add public address type to mac address field
* Add flags EIR and update eir to handle flags field
@finger563 finger563 added bug Something isn't working nfc ndef labels Oct 16, 2023
@finger563 finger563 merged commit 32042a2 into main Oct 16, 2023
39 checks passed
@finger563 finger563 deleted the bugfix/ndef branch October 16, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ndef nfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant