Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add creationMethod for parity traces #280

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsvisa
Copy link

@jsvisa jsvisa commented Nov 5, 2024

a successor of #271.

@mriccobene It seems I need an erigon mainnet instance, then can run the rpc tests over them, but sorry I don't have one, so I simplify replace the words like below:

cd integration/mainnet
sed -i 's/"createType": "call"/"creationMethod": "create"/g' trace_*/*.json
sed -i 's/"createType":/"creationMethod":/g' trace_*/*.json

@mriccobene
Copy link
Member

@jsvisa use your branch jsvisa:feature/add_creationMethod_for_parity_traces in the rpc test workflow of your PR. It will be executed on our infrastructure

@mriccobene mriccobene self-requested a review November 5, 2024 10:04
@jsvisa jsvisa force-pushed the feature/add_creationMethod_for_parity_traces branch from 183e626 to ffb9462 Compare November 7, 2024 04:12
@jsvisa
Copy link
Author

jsvisa commented Nov 7, 2024

@mriccobene I've updated this branch, and also fix a hardcoded issue ref erigontech/erigon@b75ae2f

@mriccobene
Copy link
Member

When the corresponding feature erigontech/erigon#12557 is merged on Erigon we will be able to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants