Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit service instance #340

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Sep 5, 2023

Summary

Relates to #289
Fixes: #341
Fixes: #342

Occurred changes and/or fixed issues

  • when editing a service instance that's in state 'deployed' we'd wait for the not-ready state which was never reached
  • we now just wait for the service instance to be created
  • also fixed failure message

- when editing a service instance that's in state 'deployed' we'd wait for the `not-ready` state which was never reached
- we now just wait for the service instance to be created
- also fixed failure message
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf added the kind/bug Something isn't working label Sep 6, 2023
@richard-cox richard-cox merged commit 1e76e0a into epinio:main Sep 6, 2023
5 checks passed
@richard-cox richard-cox deleted the fix-edit-service branch September 6, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
2 participants