Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom variables validation in Application edit mode #325

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Fix custom variables validation in Application edit mode #325

merged 3 commits into from
Sep 4, 2023

Conversation

torchiaf
Copy link
Contributor

@torchiaf torchiaf commented Sep 1, 2023

Summary

Fixes #299

Technical notes summary

  • Disable 'Save' button when the custom settings are not valid
  • Disable 'Update Source' when the custom settings in the Details tab are not valid.
  • Show errors in Details tab's header.

Screenshot/Video

In the example below, the validation failed because 'foo' field has a minimum value.

Button Disabled
image

Tab errors
image

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf self-assigned this Sep 1, 2023
@richard-cox richard-cox added this to the v1.10.0 milestone Sep 4, 2023
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf changed the title Fix edit applications validation Fix custom variables validation in Application edit mode Sep 4, 2023
@torchiaf torchiaf added the kind/bug Something isn't working label Sep 4, 2023
@torchiaf torchiaf merged commit 87fc76d into epinio:main Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Custom Variables are not validated in Application edit mode
2 participants