Rancher UI tests without Epinio icon #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehejik
force-pushed
the
rancher-ui
branch
2 times, most recently
from
3b399f7
to
e214a61
Compare
mmartin24
requested review from
mmartin24
and removed request for
mmartin24
thehejik
force-pushed
the
rancher-ui
branch
2 times, most recently
from
603eaa6
to
5cc5f64
Compare
|
The part for using external registries and s3 couldn't work in rancher ui tests so I'd merge this as it is. Later we can implement this #236 |
thehejik
force-pushed
the
rancher-ui
branch
4 times, most recently
from
e29cba3
to
33d990b
Compare
mmartin24
reviewed
Oct 6, 2022
thehejik
commented
Oct 6, 2022
mmartin24
reviewed
Oct 6, 2022
mmartin24
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
PR looks good to me.
Checked after latest changes:
- Rancher-UI-1-Chrome Rancher-UI-1-Chrome #269 - green
- Rancher-UI-2-Firefox Rancher-UI-2-Firefox #294 - green
- STD-UI-Latest-Chrome STD-UI-Latest-Chrome #198 -> Ok the possible affected part (menu-tests).
Tested locally Firefox for visual confirmation on installation and OK:
- Change of behavior on FF tests with note to future S3 re-implementation. All updated in README.md
Just made a suggestion here to include videos if desired; if not, ok as well.
Good work!
Signed-off-by: Tomas Hehejik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rancher UI tests now using epinio ingress url address link instead of Epinio icon which is not available anymore.
master_rancher_ui_workflow.ymlinto three steps, each with its own env vars to be able login to corresponding service (rancher and epinio):epino testing by newmenu.spec.ts has been adapted in the endrancher-menu.spec.ts- basically slightly adaptedmenu.spec.ts(without login of different users)with_default_options.spec.ts(chrome) andwith_s3_and_external_registry.spec.ts(firefox) by simple unit_testmenu.spec.tsTODO:
if (ui != 'rancher)condition.[ ] re-enable external registries - and use rancher ui form for entering s3 credentials & co.subject of [Cypress] Implement adding custom registries and S3 for Rancher UI tests #236