Skip to content

Commit

Permalink
Cypress / removing manual entering of CORS (#393)
Browse files Browse the repository at this point in the history
* removing cors setting
* removing command to enter cors
  • Loading branch information
mmartin24 authored Nov 16, 2023
1 parent e3d13c4 commit 928b0b1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
image: ${{ github.event.inputs.cypress_image }}
env:
CLUSTER_NAME: local
CORS: https://${{ needs.installation.outputs.MY_HOSTNAME }}
# CORS: https://${{ needs.installation.outputs.MY_HOSTNAME }}
# Adding secrets statically
EXT_REG_USER: ${{ secrets.EPINIO_DOCKER_USER }}
EXT_REG_PASSWORD: ${{ secrets.EPINIO_DOCKER_PASSWORD }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/master_rancher_ui_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
image: ${{ inputs.cypress_image }}
env:
CLUSTER_NAME: local
CORS: https://${{ needs.installation.outputs.MY_HOSTNAME }}
# CORS: https://${{ needs.installation.outputs.MY_HOSTNAME }}
EXT_REG_USER: ${{ secrets.EPINIO_DOCKER_USER }}
EXT_REG_PASSWORD: ${{ secrets.EPINIO_DOCKER_PASSWORD }}
RANCHER_USER: admin
Expand Down
2 changes: 1 addition & 1 deletion cypress/support/functions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,7 @@ Cypress.Commands.add('epinioInstall', ({ s3Storage, extRegistry, namespace = 'ep
cy.typeValue({label: 'Domain', value: Cypress.env('system_domain')});

// Configure cors setting
cy.typeValue({label: 'Access control allow origin', value: Cypress.env('cors')});
// cy.typeValue({label: 'Access control allow origin', value: Cypress.env('cors')});

// Configure external registry
if (extRegistry === true) {
Expand Down

0 comments on commit 928b0b1

Please sign in to comment.