Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories rework: VaIcon #4032

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Roman4437
Copy link
Collaborator

No description provided.

@Roman4437 Roman4437 requested a review from asvae November 24, 2023 14:28
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one small issue, apart from that - it's perfect. 👍

components: { VaIcon },
template: '<VaIcon/>',
template: `
<div class="flex flex-col">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should be just <VaIcon name="book">.

Let's move font-awesome / ionic to "icon fonts" story

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants