Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use static file server instead of github.com #4715

Merged
merged 6 commits into from
Nov 15, 2024
Merged

ci: use static file server instead of github.com #4715

merged 6 commits into from
Nov 15, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Nov 14, 2024

fixes: #4606

@zirain zirain requested a review from a team as a code owner November 14, 2024 05:21
@zirain zirain changed the title Static file server ci: use static file server instead of github.com Nov 14, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.55%. Comparing base (c2b0ee3) to head (a60d542).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4715   +/-   ##
=======================================
  Coverage   65.55%   65.55%           
=======================================
  Files         211      211           
  Lines       31972    31972           
=======================================
  Hits        20960    20960           
  Misses       9768     9768           
  Partials     1244     1244

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
fix
74ba58c 
Signed-off-by: zirain <[email protected]>
arkodg
arkodg previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain
Copy link
Contributor Author

zirain commented Nov 14, 2024

looks like wasm test failed.

@zirain
nit
4fa4e9c 
Signed-off-by: zirain <[email protected]>
@zirain
1.23.3
97249a0 
Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from arkodg November 14, 2024 09:10
arkodg
arkodg previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team November 14, 2024 15:04
@zirain zirain requested a review from arkodg November 14, 2024 19:27
@zirain zirain enabled auto-merge (squash) November 14, 2024 23:09
@zirain zirain merged commit e48fecf into envoyproxy:main Nov 15, 2024
24 checks passed
@zirain zirain deleted the static-file-server branch November 15, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnvergence cnvergence cnvergence approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot download from github in IPv6 first cluster
3 participants
@zirain @arkodg @cnvergence