Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Ipv6 enable test #4690

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Nov 10, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@zirain zirain requested a review from a team as a code owner November 10, 2024 15:30
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (7699578) to head (768737c).

Files with missing lines Patch % Lines
internal/cmd/envoy/shutdown_manager.go 0.00% 2 Missing ⚠️
internal/gatewayapi/runner/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4690      +/-   ##
==========================================
+ Coverage   65.57%   65.58%   +0.01%     
==========================================
  Files         211      212       +1     
  Lines       31998    32035      +37     
==========================================
+ Hits        20983    21011      +28     
- Misses       9771     9781      +10     
+ Partials     1244     1243       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain force-pushed the ipv6-enable-test branch 11 times, most recently from 624842c to e05fd83 Compare November 16, 2024 01:05
@zirain zirain force-pushed the ipv6-enable-test branch 3 times, most recently from 8caa21b to e10e640 Compare November 16, 2024 08:42
@zirain zirain added the hold do not merge label Nov 16, 2024
Signed-off-by: zirain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant