-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.18.0 #768
Version 0.18.0 #768
Conversation
It appears we can't release this without the #757 |
Could you explain what you mean here? |
Now that the tests are broken, I don't think it's a good idea to release them. |
Ah yep. Linking here to our currently flaky test case. |
@karosis88 Are you ok to ship #727 as part of 0.18.0? |
according to encode/httpx#2801 (comment), the todo list also include #757 |
Okay, here's how our
The most substantial other bits of work that we have on the table right now are...
I'd probably suggest that we press on with a 0.18.0 release as we currently stand...
There's also already plenty more for us to wrap in an Thoughts, team? |
There is already an easy solution in #757 for our async cancellations. I suggest that we include that simple modification, but if you don't like it, I am fine with this changelog. |
This would be my preference yes. To my eyes #757 is too awkwardly gnarly to just wave on through, I'd like us to slow down on that and get it comprehensively correct. |
I'm happy to approve this, once the description matches the CHANGELOG. |
I will add a release date after your review. |
Let's get a release draft ready before we merge this... |
I don't recall if you're able to do that with the In any case I've created one here... https://github.com/encode/httpcore/releases/tag/untagged-71ea7b9ccfc1bfebd276 |
Changelog
0.18.0
sni_hostname
extension with SOCKS proxy. (Supportsni_hostname
extension with SOCKS proxy. #774)Extensions
fromMapping[Str, Any]
toMutableMapping[Str, Any]
. (Change type of Extensions #762)TODO