Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.18.0 #768

Merged
merged 8 commits into from
Sep 8, 2023
Merged

Version 0.18.0 #768

merged 8 commits into from
Sep 8, 2023

Conversation

karpetrosyan
Copy link
Member

@karpetrosyan karpetrosyan commented Aug 1, 2023

Changelog

0.18.0

TODO

  • Update release date

@karpetrosyan
Copy link
Member Author

It appears we can't release this without the #757

@tomchristie
Copy link
Member

It appears we can't release this without the #757

Could you explain what you mean here?

@karpetrosyan
Copy link
Member Author

Could you explain what you mean here?

Now that the tests are broken, I don't think it's a good idea to release them.
They randomly fail.

@tomchristie
Copy link
Member

Ah yep.

Linking here to our currently flaky test case.

@karpetrosyan karpetrosyan changed the title Version 0.17.4 Version 0.18.0 Aug 8, 2023
httpcore/__init__.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Pliner
Copy link
Contributor

Pliner commented Aug 9, 2023

@karosis88 Are you ok to ship #727 as part of 0.18.0?

@trim21
Copy link

trim21 commented Aug 9, 2023

according to encode/httpx#2801 (comment), the todo list also include #757

@T-256 T-256 mentioned this pull request Aug 27, 2023
3 tasks
@tomchristie
Copy link
Member

Okay, here's how our CHANGELOG for this version looks at this point in time...

The most substantial other bits of work that we have on the table right now are...

I'd probably suggest that we press on with a 0.18.0 release as we currently stand...

  • The async cancellation issues are quite involved, and I don't want us to be time pressured in resolving them.
  • This will give us time for our users to test our HTTPS proxy support before we add any further functionality there.

There's also already plenty more for us to wrap in an httpx 0.25 release - encode/httpx#2801 once we've got this httpcore release done.

Thoughts, team?

@karpetrosyan
Copy link
Member Author

There is already an easy solution in #757 for our async cancellations. I suggest that we include that simple modification, but if you don't like it, I am fine with this changelog.

@tomchristie
Copy link
Member

I am fine with this changelog.

This would be my preference yes.

To my eyes #757 is too awkwardly gnarly to just wave on through, I'd like us to slow down on that and get it comprehensively correct.

@karpetrosyan
Copy link
Member Author

In addition, I will gladly include #734 to this release. It appears to be a part of #722.

@T-256
Copy link
Contributor

T-256 commented Sep 7, 2023

In addition, I will gladly include #734 to this release. It appears to be a part of #722.

IMO they are separated from each other, But yes, I agree to include it in 0.18.0

@tomchristie
Copy link
Member

@karosis88 karosis88 requested a review from tomchristie

I'm happy to approve this, once the description matches the CHANGELOG.

@karpetrosyan
Copy link
Member Author

I will add a release date after your review.

@tomchristie
Copy link
Member

Let's get a release draft ready before we merge this...

@tomchristie
Copy link
Member

Can I draft a new release?

I don't recall if you're able to do that with the @encode/maintainers permissions.

In any case I've created one here... https://github.com/encode/httpcore/releases/tag/untagged-71ea7b9ccfc1bfebd276

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@karpetrosyan karpetrosyan merged commit 2d0945c into encode:master Sep 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants