Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove a lot of eslint-disables #631

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 27, 2023

No description provided.

@emmercm emmercm self-assigned this Aug 27, 2023
@emmercm emmercm enabled auto-merge (squash) August 27, 2023 18:15
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/20230827-remove-eslint-disables" [commands..] [options]

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #631 (2ca0ab8) into main (18c7e1c) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   93.32%   93.30%   -0.03%     
==========================================
  Files          77       77              
  Lines        4567     4568       +1     
  Branches      982      982              
==========================================
  Hits         4262     4262              
- Misses        290      291       +1     
  Partials       15       15              
Files Changed Coverage Δ
src/console/progressBarCLI.ts 93.18% <0.00%> (ø)
src/console/singleBarFormatted.ts 80.41% <ø> (ø)
src/modules/candidateGenerator.ts 97.16% <ø> (ø)
src/modules/candidatePatchGenerator.ts 95.00% <ø> (ø)
src/modules/candidatePreferer.ts 100.00% <ø> (ø)
src/modules/candidateWriter.ts 88.63% <ø> (ø)
src/modules/directoryCleaner.ts 96.36% <ø> (ø)
src/polyfill/filePoly.ts 92.30% <ø> (ø)
src/types/files/archives/rar.ts 100.00% <ø> (ø)
src/types/files/archives/sevenZip.ts 76.74% <ø> (ø)
... and 12 more

@emmercm emmercm merged commit 19112ff into main Aug 27, 2023
50 checks passed
@emmercm emmercm deleted the emmercm/20230827-remove-eslint-disables branch August 27, 2023 18:31
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant