AddStdAggs uses varargs

emer · Jun 13, 2024 · 2179b30 · 2179b30
1 parent cb496d3
commit 2179b30
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/egui/plots.go b/egui/plots.go
@@ -141,7 +141,7 @@ func (gui *GUI) NewPlotTab(key etime.ScopeKey, tabLabel string) *plotview.PlotVi
 
 // AddTableView adds a table view of given log,
 // typically particularly useful for Debug logs.
-func (gui *GUI) AddTableView(lg *elog.Logs, mode etime.Modes, time etime.Times) {
+func (gui *GUI) AddTableView(lg *elog.Logs, mode etime.Modes, time etime.Times) *tensorview.TableView {
 	if gui.TableViews == nil {
 		gui.TableViews = make(map[etime.ScopeKey]*tensorview.TableView)
 	}
@@ -150,13 +150,15 @@ func (gui *GUI) AddTableView(lg *elog.Logs, mode etime.Modes, time etime.Times)
 	lt, ok := lg.Tables[key]
 	if !ok {
 		log.Printf("ERROR: in egui.AddTableView, log: %s not found\n", key)
-		return
+		return nil
 	}
 
 	tt := gui.Tabs.NewTab(mode.String() + " " + time.String() + " ")
 	tv := tensorview.NewTableView(tt)
 	gui.TableViews[key] = tv
+	tv.SetReadOnly(true)
 	tv.SetTable(lt.Table)
+	return tv
 }
 
 // TableView returns TableView for mode, time scope

diff --git a/elog/stditems.go b/elog/stditems.go
@@ -45,7 +45,7 @@ func (lg *Logs) AddCounterItems(ctrs ...etime.Times) {
 
 // AddStdAggs adds standard aggregation items for times up to the penultimate
 // time step provided, for given stat item that was created for the final timescale.
-func (lg *Logs) AddStdAggs(itm *Item, mode etime.Modes, times []etime.Times) {
+func (lg *Logs) AddStdAggs(itm *Item, mode etime.Modes, times ...etime.Times) {
 	ntimes := len(times)
 	for i := ntimes - 2; i >= 0; i-- {
 		tm := times[i]
@@ -81,7 +81,7 @@ func (lg *Logs) AddStatAggItem(statName string, times ...etime.Times) *Item {
 			etime.Scope(etime.AllModes, times[ntimes-1]): func(ctx *Context) {
 				ctx.SetFloat64(ctx.Stats.Float(statName))
 			}}})
-	lg.AddStdAggs(itm, etime.AllModes, times)
+	lg.AddStdAggs(itm, etime.AllModes, times...)
 	return itm
 }
 

diff --git a/netview/netview.go b/netview/netview.go
@@ -941,7 +941,7 @@ func (nv *NetView) ConfigToolbar(tb *core.Toolbar) {
 	cmap := nv.ColorMapVal.AsWidget()
 	cmap.AsWidget().SetTooltip("Color map for translating values into colors -- click to select alternative.").
 		Style(func(s *styles.Style) {
-			s.Min.X.Em(20)
+			s.Min.X.Em(10)
 			s.Min.Y.Em(1.2)
 			s.Grow.Set(0, 1)
 		})