Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing BaseException to Exception so they follow Pep8 and are catchable without catching BaseExceptions #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changing BaseException to Exception so they follow Pep8 and are catchable without catching BaseExceptions #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions redvid/redvid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def setup(self):
if self.page.status_code == 200:
return True

raise BaseException('Incorrect URL format')
raise Exception('Incorrect URL format')

def scrape(self):
"""
Expand All @@ -94,7 +94,7 @@ def scrape(self):

if not self.UNQ:
Clean(self.temp)
raise BaseException('No video in this post')
raise Exception('No video in this post')

self.r_url = 'https://v.redd.it/' + self.UNQ + '/'

Expand All @@ -110,7 +110,7 @@ def scrape(self):
VQS, AQS = mpdParse(mpd.text, custom_video_qualities=max_min_qualities)

if [VQS, AQS] == [0, 0]:
raise BaseException('Qualities not found!')
raise Exception('Qualities not found!')

self.videos = VQS

Expand Down