add support for regular expressions in Tokenizers.Normalizer.replace/2
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruoss
force-pushed
the
regex-for-normalizer
branch
from
87addab
to
7a6a751
Compare
mruoss
force-pushed
the
regex-for-normalizer
branch
from
7a6a751
to
62aed67
Compare
josevalim
approved these changes
Apr 21, 2024
jonatanklosko
approved these changes
Apr 22, 2024
|
@jonatanklosko would it be possible to get a release with these additions? |
|
@mruoss Mb it's good idea to bump some deps versions - it has passed some time since last release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to my last PR #54. This adds regex support to
Tokenizers.Normalizer.replace/2viaTokenizers.Normalizer.replace_regex/2.Tokenizers.Normalizer.replace_regex/2Tokenizers.Normalizer.replace/2andTokenizers.Normalizer.replace_regex/2.BTW: Would be nice to get a release with these two additions once merged. ❤️