Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits for K8s is equal to requests #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zagganas
Copy link
Contributor

This PR ensures that the pod will get exactly instead of at least the resources specified by the user.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #34 (c3c2e4c) into master (27a1323) will decrease coverage by 0.28%.
The diff coverage is 44.73%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   55.52%   55.23%   -0.29%     
==========================================
  Files          64       64              
  Lines        2064     2091      +27     
  Branches      217      223       +6     
==========================================
+ Hits         1146     1155       +9     
- Misses        787      803      +16     
- Partials      131      133       +2     
Impacted Files Coverage Δ
...ain/java/uk/ac/ebi/tsc/tesk/config/GsonConfig.java 100.00% <ø> (ø)
...sc/tesk/config/swagger/OAuth2ClientProperties.java 88.88% <ø> (ø)
...bi/tsc/tesk/k8s/config/KubernetesClientConfig.java 92.85% <ø> (ø)
.../uk/ac/ebi/tsc/tesk/k8s/constant/K8sConstants.java 85.71% <ø> (ø)
...i/tsc/tesk/k8s/convert/ExecutorCommandWrapper.java 100.00% <ø> (ø)
...sc/tesk/k8s/convert/KubernetesObjectsSupplier.java 96.61% <ø> (ø)
.../tsc/tesk/k8s/convert/TaskmasterEnvProperties.java 91.66% <ø> (ø)
.../java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Job.java 88.88% <ø> (ø)
.../tsc/tesk/k8s/convert/data/SingleTaskStrategy.java 90.90% <ø> (ø)
...java/uk/ac/ebi/tsc/tesk/k8s/convert/data/Task.java 93.54% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18447b...c3c2e4c. Read the comment docs.

@zagganas zagganas requested a review from lvarin May 11, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant