Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved IT and adding ignore group membership to build User #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

navisatebi
Copy link

Refined IT to reflect changes.
Consolidated building user to retrieve label selector - logic moved to one single place.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #14 into master will increase coverage by 0.16%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   83.81%   83.97%   +0.16%     
==========================================
  Files          37       37              
  Lines         964      980      +16     
  Branches      101      103       +2     
==========================================
+ Hits          808      823      +15     
- Misses        107      108       +1     
  Partials       49       49              
Impacted Files Coverage Δ
.../java/uk/ac/ebi/tsc/tesk/config/security/User.java 64.16% <88.00%> (+1.43%) ⬆️
.../tesk/config/security/AuthorisationProperties.java 100.00% <100.00%> (ø)
...tesk/config/security/ElixirPrincipalExtractor.java 96.55% <100.00%> (+0.25%) ⬆️
...c/tesk/util/component/KubernetesClientWrapper.java 63.23% <100.00%> (+0.54%) ⬆️
...sc/tesk/util/component/TesKubernetesConverter.java 90.37% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389a559...49aec2f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant